Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of decisions listed in Barcodes/Regions in Toml #328

Open
Adoni5 opened this issue Feb 1, 2024 · 1 comment
Open

Validation of decisions listed in Barcodes/Regions in Toml #328

Adoni5 opened this issue Feb 1, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Adoni5
Copy link
Contributor

Adoni5 commented Feb 1, 2024

Issue

Currently decisions do not undergo any validation in TOMLs. Actions must be one of stop_receiving, unblock or proceed, but Decisions can be anything.

For example the following Region Decision -> Action will fail

[[Region]]
no_map = "banter"

But this will succeed

[[Region]]
banter = "stop_receiving"

Proposal

Propose we also check the contents of the Region using cattrs

Testing TOML

I've attached a testing toml that should fail. All these validations should happen before testing the plugins, so we should be able to test without updating the path to the index/caller. Suggest using --no-check-plugins and --no-describe during testing.

human_chr_selection.txt

@Adoni5 Adoni5 added bug Something isn't working enhancement New feature or request labels Feb 1, 2024
@Adoni5 Adoni5 mentioned this issue Feb 1, 2024
@mattloose
Copy link
Contributor

I agree - banter should not be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants