Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph size reduction? #244

Open
Luke-Poeppel opened this issue Aug 1, 2021 · 1 comment
Open

Graph size reduction? #244

Luke-Poeppel opened this issue Aug 1, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request Improvement Improvement to speed or code complexity
Milestone

Comments

@Luke-Poeppel
Copy link
Owner

Luke-Poeppel commented Aug 1, 2021

Only connect the 20-25% of closest nodes in the complete extractions. It's pretty silly that it's a completely connected graph (nearly, b.c. no overlaps). For big datasets like Essen/MC, it's still prohibitively slow when, say, ~5000 fragments are found.

Specification:
Add bound_distance_percentage argument to build_graph.

@Luke-Poeppel Luke-Poeppel added enhancement New feature or request Improvement Improvement to speed or code complexity labels Aug 1, 2021
@Luke-Poeppel Luke-Poeppel self-assigned this Aug 1, 2021
@Luke-Poeppel
Copy link
Owner Author

I tangentially mention this "future-work" strategy in the paper. Might be cool to finally do it if/when I get reviews back.

@Luke-Poeppel Luke-Poeppel added this to the v1.2.0 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Improvement Improvement to speed or code complexity
Projects
None yet
Development

No branches or pull requests

1 participant