Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to tree-related stuff #263

Open
Luke-Poeppel opened this issue Sep 15, 2021 · 0 comments
Open

Add warnings to tree-related stuff #263

Luke-Poeppel opened this issue Sep 15, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Luke-Poeppel
Copy link
Owner

I'm not [currently] interested in maintaining the tree stuff in decitala, so just add some warnings to the searches (search.rolling_tree_search(...)) that suggest using the hash-table approach instead. Something like:

The tree-based search methods are not currently maintained. We recommend using search.rolling_hash_search with a hash_table.FragmentHashTable instead. This approach is much faster.

@Luke-Poeppel Luke-Poeppel added the enhancement New feature or request label Sep 15, 2021
@Luke-Poeppel Luke-Poeppel self-assigned this Sep 15, 2021
@Luke-Poeppel Luke-Poeppel added this to the v1.2.0 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant