Added support for non-200 response code (#142)

Luxoft · May 8, 2024 · 36a27ef · 36a27ef
1 parent 8973f56
commit 36a27ef
Show file tree

Hide file tree

Showing 10 changed files with 84 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -20,6 +20,7 @@
 !.vscode/tasks.json
 !.vscode/launch.json
 !.vscode/extensions.json
+.idea
 
 # code coverage
 /coverage

diff --git a/.snapshot/all/services.ts b/.snapshot/all/services.ts
@@ -32,6 +32,21 @@ export class CategoryService extends BaseHttpService {
     }
 }
 
+@Injectable({
+    providedIn: 'root'
+})
+export class FeedbackService extends BaseHttpService {
+    constructor(http: HttpClient) {
+        super(getBasePath('', '/api/feedback'), http);
+    }
+
+    public postFeedback(): Observable<void> {
+        return this.post<void>(
+            ``,
+        );
+    }
+}
+
 @Injectable({
     providedIn: 'root'
 })

diff --git a/.snapshot/withRequestOptions/services.ts b/.snapshot/withRequestOptions/services.ts
@@ -34,6 +34,22 @@ export class CategoryService extends BaseHttpService {
     }
 }
 
+@Injectable({
+    providedIn: 'root'
+})
+export class FeedbackService extends BaseHttpService {
+    constructor(http: HttpClient) {
+        super(getBasePath('', '/api/feedback'), http);
+    }
+
+    public postFeedback(options?: $types.TypeOrUndefined<IAngularHttpRequestOptions>): Observable<void> {
+        return this.post<void>(
+            ``,
+            options,
+        );
+    }
+}
+
 @Injectable({
     providedIn: 'root'
 })

diff --git a/__tests__/swagger/OpenAPIService.spec.ts b/__tests__/swagger/OpenAPIService.spec.ts
@@ -177,6 +177,28 @@ describe('OpenAPIService tests', () => {
             expect(service.getSchemasByEndpoints(new Set<string>())).toEqual({});
         });
 
+        test('response with not 200 code', () => {
+            const spec: IOpenAPI3 = {
+                ...defaultSpec,
+                openapi: '3.0.1',
+                paths: {
+                    '/product/test': {
+                        post: {
+                            responses: {
+                                201: {
+                                    description: 'Created'
+                                }
+                            }
+                        }
+                    }
+                }
+            };
+
+            const service = new OpenAPIService(spec, guard);
+            const endpoints = service.getEndpoints();
+            expect(service.getSchemasByEndpoints(new Set<string>(endpoints))).toEqual({});
+        });
+
         test('recursion', () => {
             const spec: IOpenAPI3 = {
                 openapi: '3.0.1',

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@luxbss/gengen",
-    "version": "1.2.6",
+    "version": "1.2.7",
     "description": "Tool for generating models and Angular services based on OpenAPIs and Swagger's JSON",
     "bin": {
         "gengen": "./bin/index.js"

diff --git a/src/services/ServiceMappingService.ts b/src/services/ServiceMappingService.ts
@@ -104,7 +104,7 @@ export class ServiceMappingService {
             name: lowerFirst(actionName),
             operation: method,
             parameters: this.getUriParameters(operation.parameters),
-            returnType: this.getTypeInfo(operation.responses[200].content?.['application/json']?.schema, modelFinder),
+            returnType: this.getTypeInfo(operation.responses[200]?.content?.['application/json']?.schema, modelFinder),
             originUri
         };
 
@@ -224,6 +224,6 @@ export class ServiceMappingService {
     }
 
     private hasDownloadResponse(operation: IOpenAPI3Operation): boolean {
-        return Boolean(operation.responses[200].content?.['application/octet-stream']);
+        return Boolean(operation.responses[200]?.content?.['application/octet-stream']);
     }
 }
diff --git a/src/swagger/OpenAPIService.ts b/src/swagger/OpenAPIService.ts
@@ -179,7 +179,7 @@ export class OpenAPIService {
         return [
             ...refs,
             ...this.getRefsFromSchema(operation.requestBody?.content['application/json']?.schema),
-            ...this.getRefsFromSchema(operation.responses[200].content?.['application/json']?.schema)
+            ...this.getRefsFromSchema(operation.responses[200]?.content?.['application/json']?.schema)
         ];
     }
 

diff --git a/src/swagger/v3/operation.ts b/src/swagger/v3/operation.ts
@@ -9,7 +9,7 @@ export interface IOpenAPI3Operation {
     tags?: string[];
     parameters?: IOpenAPI3Parameter[];
     responses: {
-        200: {
+        200?: {
             description?: 'Success';
             content?: {
                 'application/json'?: {
@@ -20,6 +20,9 @@ export interface IOpenAPI3Operation {
                 };
             };
         };
+        201?: {
+            description?: 'Created';
+        };
     };
     requestBody?: {
         content: {

diff --git a/swagger.json b/swagger.json
@@ -635,6 +635,24 @@
           }
         }
       }
+    },
+    "/api/feedback": {
+      "post": {
+        "tags": [
+          "feedback"
+        ],
+        "responses": {
+          "201": {
+            "description": "Created"
+          },
+          "400": {
+            "description": "Bad Request"
+          },
+          "500": {
+            "description": "Server Error"
+          }
+        }
+      }
     }
   },
   "components": {
@@ -724,4 +742,4 @@
       }
     }
   }
-}
+}