Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License incompatible with target core library license? #134

Open
IAlibay opened this issue Oct 22, 2023 · 6 comments
Open

License incompatible with target core library license? #134

IAlibay opened this issue Oct 22, 2023 · 6 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 22, 2023

I think? LGPLv3 means that we can't keep this as a core dependency of MDAnalysis and also aim for LGPLv2.1.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 22, 2023

I'll be honest this is one of those where I'm not 100% sure because allegedly importing is not derivative work - so technically the license choice shouldn't be affected. I think we might need to kick this back to NF for clarification at some point.

@IAlibay IAlibay changed the title License incompatible with target core library license License incompatible with target core library license? Oct 22, 2023
@orbeckst
Copy link
Member

I don't think it matters: My understanding is that GridDataFormat's LGPLv3 allows making use of the API from any code and importing into any code, regardless of the calling code's license: it could be LGPLv2.1 or "sign-in-blood-here-LICENSE".

Ideally we'd have the same license in MDA core and GDF but I don't think it's a show stopper or requires us to remove it as a core dep.

@orbeckst
Copy link
Member

(Ultimately, wasn't this the whole point of relicensing MDAnalysis?)

@IAlibay
Copy link
Member Author

IAlibay commented Oct 24, 2023

@orbeckst the issue here is about how combined works happen - the Apache 2.0 issue is related to this (inherently Apache 2.0 allows you to choose whatever license you want but isn't compatible as a combined work).

I think it's still fine but I need some time to find my notes and think about it.

@orbeckst
Copy link
Member

orbeckst commented Oct 24, 2023 via email

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

This is a glaring hole in the discussion with Pam I'm afraid, the last bit I can find is the following statement from me:

"LGPLv2.1-only would relicense to GPLv3 when combined with LGPLv3+"

It's unclear if the combined work of an LGPLv2.1+ licensed code importing a LGPLv3+ licensed code wouldn't lead to a an overall LGPLv3+ package. The rationale here is that the terms of the LGPL (at least accoridng to my interpretation of the FSF) are that you can relicense to GPL, and GPL needs all it touches (either through import or otherwise) as needing to be compatible with its license.

This might be one we have to throw back to Pam, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants