Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little bugs with non-PC platforms packages #355

Open
6 tasks
mirh opened this issue Dec 25, 2022 · 0 comments
Open
6 tasks

Little bugs with non-PC platforms packages #355

mirh opened this issue Dec 25, 2022 · 0 comments

Comments

@mirh
Copy link

mirh commented Dec 25, 2022

Describe the bug
I know this is not of any priority (and how else could it be), but still.

To Reproduce

  • When you open a function, the decompiled script box in the Bytecode tab throws an error (the script editor window is fine though)
  • When exporting to PSK with umodel the "we only save PC" checks trigger and a super ugly error comes out (pressing OK will still allow you to complete the operation then)
  • When you click on a BioTlkFile object inside a package everything crash
  • When you click on a 360 soundnodewave everything crash plus there's an infinite spawning of error windows
  • When you click on 360 facefxanimset object everything crash
  • the shader viewer is offered for some materials (which I guess might somehow remotely don't be entirely meaningless for the 360, but nonetheless the thing just gets stuck in an infinite loading animation if you click to try disassembling)

Screenshots and files used to replicate this
I tried a couple of ME1 360 and LE1 PS4 files, so my uneducated guess is that any should do it.

Version information:
v6.3.0.5458

Stack trace

Decompilation Error!
ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'length')
  at LegendaryExplorerCore.Gammtek.IO.EndianReader.ToInt32(ReadOnlySpan`1 buffer, Int32 offset, Endian endianness) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Gammtek\IO\EndianReader.cs:line 696
  at LegendaryExplorer.UserControls.ExportLoaderControls.BytecodeEditor.StartFunctionScan(Byte[] data) in D:\a\1\s\LegendaryEporer\LegendaryExplorer\UserControls\ExportLoaderControls\BytecodeEditor.xaml.cs:line 150
  at LegendaryExplorer.UserControls.ExportLoaderControls.BytecodeEditor.LoadExport(ExportEntry exportEntry) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\BytecodeEditor.xaml.cs:line 126
Exception: Cannot save packages for platforms other than PC
  at LegendaryExplorerCore.PackagesMEPackage.saveCompressed(MEPackage package, Boolean isSaveAs, Boolean includeAdditionalPackageToCook. Boolean includeDependencyTable) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Packages\MEPackage.cs:line 713
  at LegendaryExplorerCore.PackagesMEPackage.saveByReconstructing(MEPackage mePackage, String path, Boolean isSaveAs, Boolean compress, Boolean includeAdditionalPackagesToCook, Boolean includeDependencyTable, Object diskIOSyncLockObject) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Packages\MEPackage.cs:line 677
  at LegendaryExplorerCore.Packages.PackageSaver.MESave(MEPackage pcc, String savePath, Boolean compress, Boolean includeAdditionalPackagesToCook, Boolean includeDependencyTable, Object diskIOSyncLock) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Packages\PackageSaver.cs:line 166
ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at System.Collections.Generic.List`1.get_Item(Int32 index)
   at LegendaryExplorerCore.TLK.ME1.ME1TalkFile.LoadTlkData(IMEPackage pcc) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\TLK\ME1\ME1TalkFile.cs:line 309
   at LegendaryExplorerCore.TLK.ME1.ME1TalkFile..ctor(IMEPackage pcc, ExportEntry export) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\TLK\ME1\ME1TalkFile.cs:line 108
   at LegendaryExplorerCore.TLK.ME1.ME1TalkFile..ctor(ExportEntry export) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\TLK\ME1\ME1TalkFile.cs:line 97
   at LegendaryExplorer.UserControls.ExportLoaderControls.TLKEditorExportLoader.LoadExport(ExportEntry exportEntry) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\TlkEditorExportLoader.xaml.cs:line 167
   at LegendaryExplorer.Tools.PackageEditor.PackageEditorWindow.Preview(Boolean isRefresh) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\Tools\PackageEditor\PackageEditorWindow.xaml.cs:line 3387
EndOfStreamException: Unable to read beyond the end of the stream.
   at System.IO.BinaryReader.InternalRead(Int32 numBytes)
   at LegendaryExplorerCore.Unreal.BinaryConverters.SCExt.SerializeBulkData(SerializingContainer2 sc, Byte[]& arr, SerializeDelegate`1 serialize) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\SerializingContainer2.cs:line 406
   at LegendaryExplorerCore.Unreal.BinaryConverters.SoundNodeWave.Serialize(SerializingContainer2 sc) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\SoundNodeWave.cs:line 24
   at LegendaryExplorerCore.Unreal.BinaryConverters.ObjectBinary.From[T](ExportEntry export, PackageCache packageCache) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\ObjectBinary.cs:line 20
   at LegendaryExplorer.UserControls.ExportLoaderControls.Soundpanel.CanReplaceAudio(Object obj) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\Soundpanel\Soundpanel.xaml.cs:line 1370
   at LegendaryExplorer.SharedUI.RelayCommand.CanExecute(Object parameter) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\SharedUI\Commands.cs:line 19
   at MS.Internal.Commands.CommandHelpers.CanExecuteCommandSource(ICommandSource commandSource)
   at System.Windows.Controls.Primitives.ButtonBase.UpdateCanExecute()
   at System.Windows.WeakEventManager.ListenerList.DeliverEvent(Object sender, EventArgs args, Type managerType)
   at System.Windows.WeakEventManager.DeliverEvent(Object sender, EventArgs args)
   at System.Windows.Input.CommandManager.RaiseRequerySuggested(Object obj)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
OverflowException: Arithmetic operation resulted in an overflow.
   at LegendaryExplorerCore.Unreal.BinaryConverters.SCExt.Serialize(SerializingContainer2 sc, HNode& node) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\FaceFXAsset.cs:line 267
   at LegendaryExplorerCore.Unreal.BinaryConverters.SCExt.Serialize[T](SerializingContainer2 sc, T[]& arr, SerializeDelegate`1 serialize) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\SerializingContainer2.cs:line 268
   at LegendaryExplorerCore.Unreal.BinaryConverters.FaceFXAnimSet.Serialize(SerializingContainer2 sc) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\FaceFXAnimSet.cs:line 36
   at LegendaryExplorerCore.Unreal.BinaryConverters.ObjectBinary.From[T](ExportEntry export, PackageCache packageCache) in D:\a\1\s\LegendaryExplorer\LegendaryExplorerCore\Unreal\BinaryConverters\ObjectBinary.cs:line 20
   at LegendaryExplorer.UserControls.ExportLoaderControls.FaceFXAnimSetEditorControl.FaceFXAnimSetHandler..ctor(ExportEntry export) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\FaceFXAnimSetEditorControl.xaml.cs:line 1237
   at LegendaryExplorer.UserControls.ExportLoaderControls.FaceFXAnimSetEditorControl.LoadFaceFXAnimset() in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\FaceFXAnimSetEditorControl.xaml.cs:line 216
   at LegendaryExplorer.UserControls.ExportLoaderControls.FaceFXAnimSetEditorControl.LoadExport(ExportEntry exportEntry) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\UserControls\ExportLoaderControls\FaceFXAnimSetEditorControl.xaml.cs:line 172
   at LegendaryExplorer.Tools.PackageEditor.PackageEditorWindow.Preview(Boolean isRefresh) in D:\a\1\s\LegendaryExplorer\LegendaryExplorer\Tools\PackageEditor\PackageEditorWindow.xaml.cs:line 3387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant