Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging/output of pipeline #260

Open
wbenoit26 opened this issue Sep 4, 2024 · 3 comments
Open

Improve logging/output of pipeline #260

wbenoit26 opened this issue Sep 4, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@wbenoit26
Copy link
Contributor

The logging that comes out of law/luigi is confusing for new users. It's quite verbose, and when something goes wrong, it can be hard to tell what happened (or, if it happened in a condor job, where to look to see what went wrong). What can we do to improve the way logging is done?

@wbenoit26 wbenoit26 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 4, 2024
@EthanMarx
Copy link
Contributor

This might be out of our control. Theres honestly just a learning curve to determining what is a law specific error and what is a task error. law attempts to help you with this with certain messages. If you have any ideas though happy to hear them

@wbenoit26
Copy link
Contributor Author

If it's not possible to turn down the number of messages from law, then one thing I was thinking of was trying to be more explicit about what's going on using our own logging. I've noticed myself slipping on the amount of logging statements I have, just because I've already got a good sense of what's going on. Obviously there's a limit to how much we want to output, but I think we could add more messages indicating what's happening at the current moment (and make it clear that the message is coming from Aframe, rather than from law)

@EthanMarx
Copy link
Contributor

Yeah very true - need to figure out how to get a hold of the logger for logging to console from tasks.

For condor jobs theres not much we can do - users can inspect the condor job logs themselves. We can add logging to the depoyment task however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants