Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when Setting Up bench_runner on EC2 Instance #8

Closed
MAMV3x3 opened this issue Oct 19, 2023 · 2 comments
Closed

Error when Setting Up bench_runner on EC2 Instance #8

MAMV3x3 opened this issue Oct 19, 2023 · 2 comments
Assignees

Comments

@MAMV3x3
Copy link
Collaborator

MAMV3x3 commented Oct 19, 2023

Description

When attempting to set up bench_runner to run pyperformance benchmarks on an EC2 instance for the cinder repo, I encountered an AssertionError during the installation process.

Steps to reproduce

  1. Followed the instructions provided by the Faster CPython project's Benchmarking tools.
  2. Created an EC2 instance.
  3. Set up a fresh repository as per documentation: cinder_bench_runner
  4. Added git+https://github.com/faster-cpython/bench_runner@v0.2.2#egg=bench_runner to a requirements.txt file.
  5. Installed the requirements using python -m pip install -r requirements.txt.
  6. Executed python3 -m bench_runner.scripts.install.

Expected Behavior:

The bench_runner should set up without errors, generating necessary files in .github/workflows and other configurations at the root of the repository.

Actual Behavior:

Encountered the following error:

❯ python -m bench_runner.scripts.install
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/mamv3x3/cinder_bench_runner/venv/lib/python3.10/site-packages/bench_runner/scripts/install.py", line 161, in <module>
    main(args.check)
  File "/home/mamv3x3/cinder_bench_runner/venv/lib/python3.10/site-packages/bench_runner/scripts/install.py", line 139, in main
    generator(path, WORKFLOW_PATH / (path.name[:-8] + ".yml"), check)
  File "/home/mamv3x3/cinder_bench_runner/venv/lib/python3.10/site-packages/bench_runner/scripts/install.py", line 108, in generate_benchmark
    available_runners = [r for r in runners.get_runners() if r.available]
  File "/home/mamv3x3/cinder_bench_runner/venv/lib/python3.10/site-packages/bench_runner/runners.py", line 39, in get_runners
    assert len(runners)
AssertionError

Would appreciate any help or guidance to resolve this issue!

@MAMV3x3
Copy link
Collaborator Author

MAMV3x3 commented Oct 19, 2023

It seems that the bench_runner installation script may be expecting a runner to be already set up. The error suggests it's attempting to identify available runners but isn't finding any, leading to the AssertionError. I'll try setting up the GitHub Actions self-hosted runner first and then rerun the installation script to see if it resolves the issue.

@MAMV3x3
Copy link
Collaborator Author

MAMV3x3 commented Oct 20, 2023

This issue has been resolved, as documented in the steps provided in #9. Closing this issue now. Thank you for the insights and assistance!

@MAMV3x3 MAMV3x3 closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant