Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array-based input in advanced packages #2041

Open
wpbonelli opened this issue Oct 19, 2024 · 1 comment
Open

Array-based input in advanced packages #2041

wpbonelli opened this issue Oct 19, 2024 · 1 comment

Comments

@wpbonelli
Copy link
Contributor

wpbonelli commented Oct 19, 2024

Posting after discussion with @jdhughes-usgs and @emorway-usgs. I may be mischaracterizing the issue, please correct if so

Is your feature request related to a problem? Please describe.
Some standard packages (RCH/A and EVT/A) support both array-based and list-based input. Advanced packages support only list-based input.

Describe the solution you'd like
Advanced packages could also support array-based input where applicable.

As part of this effort packages could also standardize internal data structures after package load. Currently different logic is needed depending whether input is list-based or array-based.

Describe alternatives you've considered
NA

Additional context
Motivations for this are

  • consistent internal handling of boundary package data structures
  • flopy IO efficiency

This came up in the context of a PRT FMI issue reported by @mnfienen (#2042)

@mnfienen
Copy link

@wpbonelli - I'm a huge fan of allowing array-based input more generally. In particular, UZF files can really bloat when always using list-based input only. If it helps on the internals, all the better!

wpbonelli added a commit that referenced this issue Nov 3, 2024
Temporary fix for #2042, pending a more complete solution for #2041 where ideally we can standardize treatment of array- and list-based input and avoid the special handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants