Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If not generating a climatology, the climatology bounds should not be checked #780

Open
xylar opened this issue Feb 8, 2021 · 5 comments
Labels

Comments

@xylar
Copy link
Collaborator

xylar commented Feb 8, 2021

@alicebarthel found this in runs that start at year 50 (but 21 to 30 are the defaults).

The same should be true for time series and climate indices.

@xylar xylar added the bug label Feb 8, 2021
@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2021

@alicebarthel, any other comments on this?

@xylar xylar added the priority label Mar 29, 2021
@xylar xylar removed the priority label Apr 11, 2021
@xylar
Copy link
Collaborator Author

xylar commented Apr 11, 2021

I've looked into this. It might be kind of tricky. It will likely involve creating a task to update the bounds with dependencies on other tasks. I'll give it a whirl. But since it's not an easy fix, I'm demoting it to not being a high priority right now.

@xylar
Copy link
Collaborator Author

xylar commented Apr 11, 2021

The task approach doesn't work. The bounds get updated too late to be useful. Still thinking about how to solve this.

@milenaveneziani
Copy link
Collaborator

@xylar: my only suggestion would be, when one runs with the --verbose flag, to add a comment before or after the bounds checking of the like "Warning: climatology bounds are checked even if climatology task is off".

@xylar
Copy link
Collaborator Author

xylar commented Apr 11, 2021

Yeah, that might be an easy interim solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants