Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread queue hangs with capacity 1 #2708

Open
Lestropie opened this issue Sep 4, 2023 · 0 comments
Open

Thread queue hangs with capacity 1 #2708

Lestropie opened this issue Sep 4, 2023 · 0 comments
Labels

Comments

@Lestropie
Copy link
Member

In #2269, specifically d0b3afa, I reduce the capacity of the multi-threading queue that stores the shuffling matrices, since there isn't really any need to buffer data there, it may use extra memory for large datasets, and has an added benefit of providing more faithful progress information since that's reported by the source.

I decided heuristically to set the capacity of the queue to the number of threads in use.

However I found that when using -nthreads 1, such that the threading queue is set up (unlike -nthreads 0) but has capacity 1, the program hangs.

Might not be worth the effort trying to get the code working robustly with a capacity of 1. Can just make sure it's at least 2. But will need to make sure it's done for both normal and ordered queues.

@Lestropie Lestropie added the bug label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant