Add periodic checks with sanitizers #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daljit46
force-pushed
the
san_checks
branch
2 times, most recently
from
54a74fb
to
175bb9f
Compare
|
After the discussion today, I think it may make sense to wait for this PR to be merged until most issues spotted by the sanitizers have been fixed on dev. |
This was referenced Jan 10, 2024
|
I think this is mostly ready to be merged. All of issues mentioned in #2772 seems to have fixed apart from #2779. I think that's still waiting a review from @jdtournier. EDIT: never mind, it seems that TSAN has spotted other bugs, so we should fix those too. |
daljit46
changed the title
|
All tests are now passing, so I think this is now mergeable. |
Lestropie
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitizers are very valuable tools to detect problems by instrumenting code for runtime bug detection. They have already proven useful for us as demonstrated in #2760, #2761 and #2755.
This PR adds a new GitHub Actions workflow that runs our unit and binary tests compiled with sanitizers provided by LLVM each night. It'd be rather computationally expensive to run these checks on pull requests, but my tests show that they are fast enough to be run once a day (with caching enabled).
Note that this PR must be merged into
mastersince scheduled GitHub Actions only run on the default or base branch.