Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameGenerator should provide access to other FrameCutter parameters #130

Open
2 of 9 tasks
jmarcosfer opened this issue Sep 23, 2023 · 0 comments
Open
2 of 9 tasks

FrameGenerator should provide access to other FrameCutter parameters #130

jmarcosfer opened this issue Sep 23, 2023 · 0 comments

Comments

@jmarcosfer
Copy link
Collaborator

jmarcosfer commented Sep 23, 2023 •
edited
Loading

What is the issue about?

  • Bug
  • Feature request
  • Usage question
  • Documentation
  • Contributing / Development

What part(s) of Essentia.js is involved?

  • essentia.js-core (vanilla algorithms)
  • essentia.js-model (machine learning algorithms)
  • essentia.js-plot (plotting utility module)
  • essentia.js-extractor (typical algorithm combinations utility)

Description

FrameGenerator algorithm should provide parameters "lastFrameToEndOfFile", "startFromZero" and "validFrameThresholdRatio" to be passed to FrameCutter internally, as upstream Essentia library does.

Proposed solution

  • This is easy to change in existing C++ wrapper, here and here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmarcosfer