Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Creating EMARs #122

Closed
2 tasks done
abhsarma opened this issue Jul 30, 2024 · 7 comments
Closed
2 tasks done

Issues with Creating EMARs #122

abhsarma opened this issue Jul 30, 2024 · 7 comments
Assignees
Labels

Comments

@abhsarma
Copy link
Collaborator

abhsarma commented Jul 30, 2024

We want to support export of multiverse analysis to EMARs. While we have a working implementation thanks to @hwangkyle, there are still some pending issues (including #116).

Broadly, this is due to how things are implemented in knitr:

@abhsarma abhsarma self-assigned this Jul 30, 2024
@abhsarma
Copy link
Collaborator Author

For the second issue, I think it can be solved by again providing an optional argument to eng_r to control the behavior of plot_counter() which will almost always be FALSE except for this specific use case. But I am apprehensive of just jumping to this solution. @mjskay thoughts?

@mjskay
Copy link
Contributor

mjskay commented Jul 31, 2024

hmm I dunno. What is plot_counter()?

@abhsarma
Copy link
Collaborator Author

abhsarma commented Jul 31, 2024

It's a knitr internal function but it's not documented / described, so I have no idea---which is why I'm asking

@mjskay
Copy link
Contributor

mjskay commented Jul 31, 2024

hmm I dunno, try reading or stepping through the code to figure out what it does? Or ask the knitr folks...

@abhsarma
Copy link
Collaborator Author

the second one seems like is solved by changing the chunk label during knitting to be unique

@abhsarma abhsarma added this to the CRAN release v0.7 milestone Aug 1, 2024
abhsarma added a commit that referenced this issue Aug 1, 2024
@abhsarma
Copy link
Collaborator Author

abhsarma commented Aug 3, 2024

This has been filed as an issue / PR in knitr. See: yihui/knitr#2358
I am hoping this will be fixed when they have updated it on their end, if not it will be reopened.

@abhsarma abhsarma closed this as completed Aug 3, 2024
@mjskay
Copy link
Contributor

mjskay commented Aug 4, 2024

As a process suggestion, if this issue is not fixed yet here and is waiting on a change in knitr, I would leave it open so that it is still tracked here (and someone coming along with that problem can find it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants