Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension with config data raises an error. #8

Open
sander76 opened this issue Dec 8, 2018 · 7 comments
Open

extension with config data raises an error. #8

sander76 opened this issue Dec 8, 2018 · 7 comments

Comments

@sander76
Copy link
Contributor

sander76 commented Dec 8, 2018

@MadLittleMods Just checking: Has this ever worked?

md = markdown.Markdown(extensions=['iconfonts(prefix=mypref-)'])

Adding the prefix=mypref- raises an error with the latest version of markdown.

@sander76
Copy link
Contributor Author

sander76 commented Dec 8, 2018

@MadLittleMods I know. I ran them. They failed when you include the extra config data inside quotes. If you look at the markdown docs it doesn't show the option. That's why I was wondering: could it be it is not supported anymore? Thinking further, should the current code be considered legacy and start a new plugin (or new version) supporting only the current version of markdown and python version>3.4 ?

@MadLittleMods
Copy link
Owner

@sander76 Yes, it was only tested in older versions of Markdown and is why I asked you if it worked here, #6 (comment)

@sander76
Copy link
Contributor Author

sander76 commented Dec 8, 2018

@MadLittleMods I guess I was a bit quick on the conclusion. I have been using your plugin for a couple of years, but only with the "basic" configuration which works just fine. After I found out it worked for me I thought all was fine not really looking at the other options the plugin provides.... 🙄.

So not sure how to proceed now...

@sander76
Copy link
Contributor Author

sander76 commented Dec 8, 2018

@MadLittleMods Sorry about this

@sander76
Copy link
Contributor Author

sander76 commented Dec 8, 2018

@MadLittleMods I am totally fine to create a trimmed down version of your plugin and giving you all credits. I don't think I can live up to the expectation of both keeping backwards compatibility, upgrading to the new markdown version and keeping all config options intact....

@MadLittleMods
Copy link
Owner

MadLittleMods commented Dec 8, 2018

@sander76 We can create a new v3 branch for use with the latest Python markdown version

Since it is a major version, it can have breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants