Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot clone MT32Emu/munt due to updated GitHub security #41

Closed
shinra-electric opened this issue Mar 25, 2022 · 5 comments
Closed

Cannot clone MT32Emu/munt due to updated GitHub security #41

shinra-electric opened this issue Mar 25, 2022 · 5 comments

Comments

@shinra-electric
Copy link

When updating the submodules, cloning munt will fail:

Submodule 'munt' (git://github.com/munt/munt.git) registered for path 'Vendor/MT32Emu/munt'
Cloning into '/Users/xianmo/Downloads/Boxer/Vendor/MT32Emu/munt'...
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/munt/munt.git' into submodule path '/Users/xianmo/Downloads/Boxer/Vendor/MT32Emu/munt' failed

The reason for the failure is updated security on GitHub which is described here.

I searched a bit for fixes, and I found this example from another project where they change the git path to github.

So if git://github.com/munt/munt.git is changed to github:munt/munt.git it might fix the issue.

@shinra-electric
Copy link
Author

This is odd, because the .gitmodules file has the url as https://github.com/MaddTheSane/Boxer-MT32Emu.git which should be fine...

@shinra-electric
Copy link
Author

shinra-electric commented Mar 25, 2022

Ah, if you go to here you can see the old path.

Edit: Although after manually editing and retrying, it still fails with the same error. The old git address must be somewhere else too.

@kyods
Copy link

kyods commented Mar 25, 2022

Go to Boxer/.git/modules/Vendor/Boxer-MT32Emu, and in the config file change:

[submodule "munt"]
	active = true
	url = git://github.com/munt/munt.git

to:

[submodule "munt"]
	active = true
	url = https://github.com/munt/munt.git

This should do the trick.

@shinra-electric
Copy link
Author

Yes, that worked. Though I should mention that the modules folder is only created after trying to update the submodules once.

@MaddTheSane
Copy link
Owner

This should be fixed by commit 5f209fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants