Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default calendar: nextDaysRelative not working #3603

Open
evroom opened this issue Oct 26, 2024 · 9 comments
Open

Default calendar: nextDaysRelative not working #3603

evroom opened this issue Oct 26, 2024 · 9 comments

Comments

@evroom
Copy link

evroom commented Oct 26, 2024

Default calendar: the nextDaysRelative parameter seems to not work.
The timeformat remains absolute for events on today and tomorrow.

$ grep version /home/admin/MagicMirror/package.json
	"version": "2.30.0-develop",
nextDaysRelative
If this is set to true, the appointments of today and tomorrow are displayed relatively,
even if the timeformat is set to absolute.

timeFormat: "absolute",
nextDaysRelative: false,
nextDaysRelative_false

timeFormat: "absolute",
nextDaysRelative: true,
nextDaysRelative_true

@sdetweil
Copy link
Collaborator

sdetweil commented Oct 26, 2024

can you post config please
this is develop pulled down when? (just checking)

@evroom
Copy link
Author

evroom commented Oct 26, 2024

Did the git pull on approx. Sat 26 Oct 10:45:00 CEST 2024.

config.js (removed personal entries):

config.js.txt

@sdetweil
Copy link
Collaborator

nextDaysRelative is only for full day events AND timeFormat : "absolute" according to the code

you only showed duration events, not full day

@evroom
Copy link
Author

evroom commented Oct 26, 2024

Okay, that is not mentioned in the documentation.

But indeed that is what it does:

nextDaysRelative_fullday_true

@sdetweil
Copy link
Collaborator

i think its encoded in the name
next DAYS relative

@evroom
Copy link
Author

evroom commented Oct 26, 2024

For a Sherlock Holmes like you perhaps :-)
It wasn't clear for a regular user like me.
I read next days as today, tomorrow, day after tomorrow.
The text narrowed this down to today and tomorrow.

Opened this anyway:
MagicMirrorOrg/MagicMirror-Documentation#267

Please close this issue (#3603) when it is meant to be for fullday events only.
Otherwise the issue will address the fact that it is not working non-fullday events events.

@sdetweil
Copy link
Collaborator

sdetweil commented Oct 26, 2024

relative only matters for full day events

Saturday 16:00-18:00 displayed as Today
and
Sunday, 16:00-18:00 displayed as Tomorrow

seem illogical to me

go fishing w Bob, Oct 26
and
spend the day w Sue, Oct 27

make me try to envision when those days are ( today is saturday, some day of the month)

Today and Tomorrow clear it up instantly

@evroom
Copy link
Author

evroom commented Oct 26, 2024

With timeFormat: "relative" you'll get:
timeFormat_relative_all_events
Makes sense to me.

So if I get the same result with timeFormat: "absolute" and nextDaysRelative then I think that would be nice.

But when 'we' leave it be, then it would be nice for a re-wording in the calendar document just make it more clear.

PS

timeFormat: "relative",
dateFormat: "ddd MMM D - HH:mm",
dateEndFormat: "ddd MMM D - HH:mm",
fullDayEventDateFormat: "ddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
nextDaysRelative: false

Does showEnd apply to timed events too, or only to fullday event ?
Because with the above settings, I do not see the date end.
All my latest testing was only done with timeFormat: "absolute", whereas my "production" MagicMirror uses relative (which I need to give a second thought).

@sdetweil
Copy link
Collaborator

sdetweil commented Oct 26, 2024

absolute and releative produce different results

Does showEnd apply to timed events too, or only to fullday event ?

see #3602

fixed in test version
I have just updated the doc (develop branch) for nextDaysRelative and showEndsOnlyWithDuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants