This repository has been archived by the owner on May 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Here's a WIP to be continued in the next Zerg Rush. As of now, looks ok-ish:
Here're some considerations:
Input-placeholder mixin hasn't been imported
There were two appearances of that mixin within the messaging Sass file of Timemarket, which have been removed because they depended on other mixins from the same library. With this, it looks like it can be solved:
http://stackoverflow.com/questions/20773665/fail-to-change-placeholder-color-with-bootstrap-3
Anyhow, the styling only changed the font-color and it set the italics style, so no big deal.
Needs to adjust to the page
The current styles take into consideration a top nav-bar and thus create a blank space in the footer when this one isn't present.
Lots of styles are imported from other libraries
Some come from Compass, some from Bootstrap and some from a Jquery library called Jquery.mCustomScrollbar.js/css
I've included some of these in the module, but if you want to polish some other styles that might be more common (forms, borders, badges, etc.) we might want to reuse some already existing ones, or else import them into the module - or as a general component.
Glitches
Currently, when switching from a selected message to another, the text becomes underlined for a fraction of a second, creating a weird visual effect. Not a big deal, but definitely worth looking into.
TODO
Best,