Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Add chat component (WIP) #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add chat component (WIP) #34

wants to merge 3 commits into from

Conversation

alexrodba
Copy link
Member

Hi all,

Here's a WIP to be continued in the next Zerg Rush. As of now, looks ok-ish:
image

Here're some considerations:

Input-placeholder mixin hasn't been imported
There were two appearances of that mixin within the messaging Sass file of Timemarket, which have been removed because they depended on other mixins from the same library. With this, it looks like it can be solved:
http://stackoverflow.com/questions/20773665/fail-to-change-placeholder-color-with-bootstrap-3

Anyhow, the styling only changed the font-color and it set the italics style, so no big deal.

Needs to adjust to the page
The current styles take into consideration a top nav-bar and thus create a blank space in the footer when this one isn't present.

Lots of styles are imported from other libraries
Some come from Compass, some from Bootstrap and some from a Jquery library called Jquery.mCustomScrollbar.js/css

I've included some of these in the module, but if you want to polish some other styles that might be more common (forms, borders, badges, etc.) we might want to reuse some already existing ones, or else import them into the module - or as a general component.

Glitches
Currently, when switching from a selected message to another, the text becomes underlined for a fraction of a second, creating a weird visual effect. Not a big deal, but definitely worth looking into.

TODO

  • I'm sure that not all the attributes in the frontmatter aren't used, so you might want to remove them.
  • Check the random-user photos. I removed the timemarket guys, but I don't know who the rest are.

Best,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant