Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where multi-sector writes will be prefixed by FF FF FF FF #197

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Fix a bug where multi-sector writes will be prefixed by FF FF FF FF #197

wants to merge 5 commits into from

Conversation

jpmeijers
Copy link

@jpmeijers jpmeijers commented Feb 20, 2020 •
edited by Marzogh
Loading

This change moves the first chip select, mode write, and address write into the less-than-one-sector write case. If this is not done the chip select, mode write, and address write will be done twice for the first sector of a multi-sector write.

Pull request details

  • Please check if the PR fulfils these requirements
  • The commit message/s explain/s all the changes clearly
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Added feature
  • Documentation update
  • Other - Please explain here:

GitHub issue state GitHub issue title GitHub issue author GitHub issue label GitHub issue comments GitHub issue age GitHub issue last updateGitHub pull request check contexts

Marzogh and others added 5 commits April 20, 2019 22:55
@Marzogh
Merge pull request Marzogh#170 from Marzogh/master
dae23b2 
Updated pull requests and issue templates
@Marzogh
Merge pull request Marzogh#178 from Marzogh/development
2711ccc 
Latest stable changes from development - Custom SPI pins and multiple SPI support for ESP32
@Marzogh
Merge pull request Marzogh#179 from Marzogh/development
82db983 
Final code for v3.4.0 from Development
@Marzogh
Merge pull request Marzogh#180 from Marzogh/stable
1f1e4de 
Final code for v3.4.0 from Stable
@jpmeijers
Fix a bug where multi-sector writes will be prefixed by FF FF FF FF
5ccadff 
This change moves the first chip select, mode write, and address write into the less-than-one-sector write case. If this is not done the chip select, mode write, and address write will be done twice for the first sector of a multi-sector write.
Marzogh
Marzogh approved these changes Sep 16, 2021
View reviewed changes
Copy link
Owner

@Marzogh Marzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@Marzogh Marzogh self-assigned this Sep 16, 2021
@Marzogh Marzogh added this to the v3.4.1 milestone Sep 16, 2021
@Marzogh Marzogh added the bugfix Fixes an existing bug in the current version of the code label Sep 16, 2021
@Marzogh Marzogh changed the base branch from master to development September 16, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marzogh Marzogh Marzogh approved these changes

Assignees

@Marzogh Marzogh

Labels
bugfix Fixes an existing bug in the current version of the code
Projects
None yet
Milestone
v3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmeijers @Marzogh