Added new ManID #229
Open
Added new ManID #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated pull requests and issue templates
Latest stable changes from development - Custom SPI pins and multiple SPI support for ESP32
Final code for v3.4.0 from Development
Final code for v3.4.0 from Stable
Added EON manufacturer memory ID (0x1C) in the list of supported IDs inside the "SPIFlash.h" file and the respective preprocessor macro in the "defines.h" file.
Marzogh
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EN25QH16B(2A).pdf
Added EON manufacturer memory ID (0x1C) in the list of supported IDs inside the "SPIFlash.h" file and the respective preprocessor macro in the "defines.h" file.
Pull request details
What is the current behavior? (You can also link to an open issue here)
"FlashDiagnostics" and "TestFlash" sketches doesn't work with Eon memory EN25QH16B due to fail check of the supported Manufacturer ID in "SPIFlashIO.h ", "_chipID" method, lines 540-545 and the later check at line 563.
A simple call of the flash.begin with a specified flash memory size as a parameter didn't make it work.
What is the new behavior? (if this is a feature change)
As the manufacturer ID of Eon is added the check for supported ID passes and all other required information (namely capacity and supported) is provided and the sketches work properly
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
DO NOT DELETE OR EDIT anything below this
Note 1: Make sure to add all the information needed to understand the bug so that someone can help. If any essential information is missing we'll add the 'Needs more information' label and close the issue until there is enough information.
Note 2: For support questions (for example, tutorials on how to use the library), please use the Arduino Forums. This repository's issues are reserved for feature requests and bug reports.