Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocessor option for asynchronous erase support #253

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

LithosphereRocketry
Copy link

Pull request details

  • Please check if the PR fulfills these requirements
  • The commit message/s explain/s all the changes clearly
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Added feature
  • Documentation update
  • Other - Please explain here:
  • What is the current behavior? (You can also link to an open issue here)

When erasing a page, the current library busy-waits until the erase is confirmed completed.

  • What is the new behavior? (if this is a feature change)

When ERASE_ASYNC is defined, the wait for the chip to be ready is removed. This should not impact reliability in most cases, as all functions wait for ready at the start of execution as well.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

It removes a check for ready at the beginning of suspendProg(); this should break almost nothing, as suspendProg() has no purpose without this PR, but it in theory could introduce some strange behavior e.g. if you try to suspend during a whole-chip erase.

  • Other information:

I couldn't for the life of me get Sphinx working on my system, so the HTML docs aren't built, but the source files are updated.

Currently only tested on STM32 with W25Q128 as that's the hardware I have on hand - would appreciate testing on other configurations.


DO NOT DELETE OR EDIT anything below this

Note 1: Make sure to add all the information needed to understand the bug so that someone can help. If any essential information is missing we'll add the 'Needs more information' label and close the issue until there is enough information.

Note 2: For support questions (for example, tutorials on how to use the library), please use the Arduino Forums. This repository's issues are reserved for feature requests and bug reports.


GitHub issue state GitHub issue title GitHub issue author GitHub issue label GitHub issue comments GitHub issue age GitHub issue last updateGitHub pull request check contexts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants