diff --git a/.github/workflows/pythonapp.yaml b/.github/workflows/pythonapp.yaml index f87bf351..0bb06769 100644 --- a/.github/workflows/pythonapp.yaml +++ b/.github/workflows/pythonapp.yaml @@ -44,7 +44,7 @@ jobs: - name: List tox envs run: tox -l - name: Test with tox - run: tox -e duckdb_master,ibis --verbose + run: tox -e duckdb_master --verbose if: matrix.bleeding_edge - name: Test with tox run: tox --verbose diff --git a/duckdb_engine/tests/test_ibis.py b/duckdb_engine/tests/test_ibis.py deleted file mode 100644 index d9f9c03b..00000000 --- a/duckdb_engine/tests/test_ibis.py +++ /dev/null @@ -1,44 +0,0 @@ -""" -these are largely just smoke tests -""" - -from csv import DictWriter -from pathlib import Path -from typing import TYPE_CHECKING - -from pytest import fixture, importorskip -from sqlalchemy import text - -importorskip("ibis") - -if TYPE_CHECKING: - from ibis.backends.duckdb import Backend - - -@fixture -def ibis_conn() -> "Backend": - import ibis - - return ibis.duckdb.connect() - - -def test_csv(tmp_path: Path, ibis_conn: "Backend") -> None: - path = tmp_path / "test.csv" - with path.open("w") as fh: - cfh = DictWriter(fh, ["mean"]) - cfh.writeheader() - cfh.writerow({"mean": 6}) - - ibis_conn.register(f"csv://{path}") - - -def test_pandas(ibis_conn: "Backend") -> None: - pandas = importorskip("pandas") - df = pandas.DataFrame({"mean": [6]}) - ibis_conn.register(df) - - -def test_method_call(ibis_conn: "Backend") -> None: - importorskip("pyarrow") - with ibis_conn._safe_raw_sql(text("select 1")) as cursor: - cursor.cursor.fetch_record_batch() diff --git a/tox.ini b/tox.ini index 9def8616..f4370337 100644 --- a/tox.ini +++ b/tox.ini @@ -35,11 +35,6 @@ require_poetry = True commands = mypy . -[testenv:ibis] -commands = - pip install ibis-framework[duckdb] - pytest --junitxml=results.xml --cov --cov-report xml:coverage.xml --verbose -rs -k ibis - [gh-actions] python = 3.7: py37-{duckdb040,duckdb051,duckdb061,duckdb071,duckdb081}-sqlalchemy{13,14,20}