Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Struct and Map TypeEngine subclasses are missing type information #654

Open
1 task done
cpcloud opened this issue May 18, 2023 · 2 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@cpcloud
Copy link
Contributor

cpcloud commented May 18, 2023

What happened?

This is more of a feature request, but it appears that the Struct and Map types are missing type information, which makes them not so useful for type inference for duckdb inside of ibis. We have our own sqlalchemy types to deal with this, so it's not a huge problem at the moment, but I thought I'd raise it here.

DuckDB Engine Version

0.7.2

DuckDB Version

0.7.1

SQLAlchemy Version

1.4.48

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cpcloud cpcloud added the bug Something isn't working label May 18, 2023
@Mause
Copy link
Owner

Mause commented May 18, 2023

Heya,

I'd actually begun work on this after the PR yesterday already, so I'll put it up once it's ready (in the next few days hopefully), and see if it's fit for your purposes

@cpcloud
Copy link
Contributor Author

cpcloud commented May 18, 2023

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants