Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use numeric_dollar where available #836

Merged
merged 5 commits into from
Dec 5, 2023

test: add assertion

b51f838
Select commit
Loading
Failed to load commit list.
Refresh
Merged

fix: use numeric_dollar where available #836

test: add assertion
b51f838
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 5, 2023 in 0s

57.14% of diff hit (target 90.60%)

View this Pull Request on Codecov

57.14% of diff hit (target 90.60%)

Annotations

Check warning on line 433 in duckdb_engine/tests/test_basic.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

duckdb_engine/tests/test_basic.py#L433 

Added line #L433 was not covered by tests

Check warning on line 446 in duckdb_engine/tests/test_basic.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

duckdb_engine/tests/test_basic.py#L445-L446 

Added lines #L445 - L446 were not covered by tests
View more details on Codecov