Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify expected result of GetECG when no ECG present. #115

Open
SteveKauffman opened this issue Nov 8, 2018 · 1 comment
Open

Clarify expected result of GetECG when no ECG present. #115

SteveKauffman opened this issue Nov 8, 2018 · 1 comment
Milestone

Comments

@SteveKauffman
Copy link
Member

When the TestViewer.exe is run on an image that has no ECG data, we were returning an EcgSeries object with 0 samples.

Unfortunately this causes TestViewer's DrawEcg() method to attempt dividing by zero.

I think we need to clarify what the expected result of GetECG() is in the case that there is no ECG data associated with the image. In C++, it makes sense for GetECG(EcgSeries* ecg) to set 'ecg' to 0. Unclear to me the impact on C# clients of the interface using EcgSeries ecg = m_source.GetECG().

Thoughts?

@forderud
Copy link
Member

forderud commented Nov 8, 2018

Good point Steve.

I don't really have any preference on if lack of ECG should be reported as E_FAIL (or other error code) and/or an empty ECG struct, Maybe #116 could be a pragmatic solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants