You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the TestViewer.exe is run on an image that has no ECG data, we were returning an EcgSeries object with 0 samples.
Unfortunately this causes TestViewer's DrawEcg() method to attempt dividing by zero.
I think we need to clarify what the expected result of GetECG() is in the case that there is no ECG data associated with the image. In C++, it makes sense for GetECG(EcgSeries* ecg) to set 'ecg' to 0. Unclear to me the impact on C# clients of the interface using EcgSeries ecg = m_source.GetECG().
Thoughts?
The text was updated successfully, but these errors were encountered:
I don't really have any preference on if lack of ECG should be reported as E_FAIL (or other error code) and/or an empty ECG struct, Maybe #116 could be a pragmatic solution?
When the TestViewer.exe is run on an image that has no ECG data, we were returning an EcgSeries object with 0 samples.
Unfortunately this causes TestViewer's DrawEcg() method to attempt dividing by zero.
I think we need to clarify what the expected result of GetECG() is in the case that there is no ECG data associated with the image. In C++, it makes sense for GetECG(EcgSeries* ecg) to set 'ecg' to 0. Unclear to me the impact on C# clients of the interface using EcgSeries ecg = m_source.GetECG().
Thoughts?
The text was updated successfully, but these errors were encountered: