Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add presentation state (default slice orientation) #91

Open
forderud opened this issue Aug 28, 2018 · 2 comments
Open

API: Add presentation state (default slice orientation) #91

forderud opened this issue Aug 28, 2018 · 2 comments
Milestone

Comments

@forderud
Copy link
Member

forderud commented Aug 28, 2018

Enable integrators to query the loaders for the default slice orientations when viewing image slices.

API: Limited "presentation state" support (GE proposal): #141

@forderud forderud added this to the 2.x milestone Aug 28, 2018
@forderud forderud modified the milestones: 2.x, 3.x Aug 28, 2018
@forderud forderud modified the milestones: 3.x, 2.x Jun 22, 2019
@ravimanaguli
Copy link

TestViewer and DummyLoader are essential for detail investigation and proper interoperability of loader DLL.

[1]
Please define range of PresentationState::GetViewCount() output. Max. value? Min. value?

[2]
What does Image3dSoruce::GetPresentationState() do?
It is [optional], is it not necessary to implement it?"

@forderud
Copy link
Member Author

TestViewer and DummyLoader are essential for detail investigation and proper interoperability of loader DLL.

Fully agree. I will personally ensure that these projects are updated after we agree on the spec.

[1] Please define range of PresentationState::GetViewCount() output. Max. value? Min. value?

I would prefer to leave that to the implementers to decide, since it will likely be difficult to agree on specific values. For GE Vivid data, we'll likely return somewhere between 1 and 12 views, depending on how the files were originally stored. PACS integrators are free to only utilize the first "N" views when loading 3rd party data, and the GE EchoPAC integration will likely only utilize the first 3-4 views returned.

[2] What does Image3dSoruce::GetPresentationState() do?
It is [optional], is it not necessary to implement it?"

Correct. A conforming implementation can e.g. return E_NOTIMPL if it doesn't support presentation state (yet). The number of views returned might also be zero if no "view" information is present in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants