[0.50.01-SNAPSHOT] Small Cockpits not shifting sensor crit upwards if the empty slot 4 crit space is occupied when change is made

[PhoenixHeart512]

Prerequisites and Pre-Issue Checklist

• I'm reporting the issue to the correct repository:

• MegaMek

• MegaMekLab

• MekHQ

• I've tested the issue against at least the latest MILESTONE version

• I've asked on the MegaMek Discord about the error

• I've reviewed the BattleTech rules and MegaMekLab documentation, and I've confirmed that something isn't working as intended.

• I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

When adding a small cockpit to a mech, the free crit slots are supposed to be contiguous, as seen on several lore mechs mounting double-crit weapons in the head with a small cockpit. For this bug report I am using an Archangel C-ANG-O Invictus, which has a 2-slot Plasma Rifle in the head:

Issue ONLY occurs if the empty head slot (slot 3) is occupied when the small cockpit change is made. The sensors are supposed shift upwards to slot 4, and the bottom life support should disappear with the small cockpit.

Instead, what is happening is that the slot 3 item blocks the sensors from shifting upwards (instead of kicking the offending equipment back to the unassigned criticals) and the sensors cannot move up, leaving slots 4 and 6 available for equipment.

If you then remove the offending equipment in slot 4 you are left with 2 separate empty slots, and unable to use 2-slot equipment in the head.

If you then switch to standard cockpit bad back to small cockpit, it moves the Sensor slot properly and leaves you with 2 contiguous free crit slots in the head.

I tried using the "compact" and "sort" buttons on the crit screen to move the sensor slot but it had no effect.

Steps to Reproduce

1. Starting with a standard cockpit
2. Place a 1-slot equipment into the empty head crit space (Endo Steel floating crit is used in the example)
3. Switch to a Small Cockpit
4. Remove the Endo Steel floating crit from the head

Operating System *

Windows 10

Java Version *

Java Version: 17.0.6

MegaMek Suite Version *

Free Text (type manually)

Custom MegaMekLab Version

megamek.MegaMek.initializeLogging(MegaMek.java:146) - Starting MegaMek v0.50.1-SNAPSHOT Build Date: 2024-10-22T03:24:07.974368271 Today: 2024-10-23 Origin Project: MekHQ Java Vendor: Eclipse Adoptium Java Version: 17.0.6 Platform: Windows 10 10.0 (amd64) System Locale: en_US Total memory available to MegaMek: 8 GB MM Code Revision: 630bba8695c2b1004e65501fe900f4e1b8c9e973 MML Code Revision: 3843803 MHQ Code Revision: 035ff6c725a948b98d811bdaac45d7375ea67074

Attach Files

No response

Final Checklist

• I've checked to make sure that this issue has not already been filed
• I'm reporting only one issue in this ticket for clarity and focus