From ec9c8a1b239f053e1dcf7ad25e9a0ae5f131cf20 Mon Sep 17 00:00:00 2001
From: Mathieu Schaer <mathieu.schaer@meteoswiss.ch>
Date: Thu, 11 Jan 2024 15:44:05 +0100
Subject: [PATCH] fix: remove parralelization with multiprocessing for valley
 and ridge index

---
 HISTORY.rst              |  3 ++-
 topo_descriptors/topo.py | 37 ++++++-------------------------------
 2 files changed, 8 insertions(+), 32 deletions(-)

diff --git a/HISTORY.rst b/HISTORY.rst
index 2cf4f37..692c42e 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -2,13 +2,14 @@
 History
 =======
 
-0.3.0 (2023-12-20)
+0.3.0 (2024-01-15)
 ------------------
 
 * Move from DataArray to Dataset for DEM object to allow transferring global attributes.
 * Add units as variable attributes.
 * Output slope in units of [degree] instead of [m / pixel].
 * Fix bug in slope calculation.
+* Remove parallelization of scales with multiprocessing for valley and ridge
 
 0.2.1 (2022-10-19)
 ------------------
diff --git a/topo_descriptors/topo.py b/topo_descriptors/topo.py
index 925d4fe..47e7e2f 100755
--- a/topo_descriptors/topo.py
+++ b/topo_descriptors/topo.py
@@ -6,7 +6,6 @@
 import dask.array as da
 from numba import njit, prange
 from scipy import ndimage, signal
-from multiprocessing import Pool, cpu_count
 
 import topo_descriptors.helpers as hlp
 from topo_descriptors import CFG
@@ -371,44 +370,20 @@ def compute_valley_ridge(
 
     scales_pxl, _ = hlp.scale_to_pixel(scales, dem_ds)
     sigmas = hlp.get_sigmas(smth_factors, scales_pxl)
+    dem_val = hlp.get_da(dem_ds).values
+    units = "1"
 
-    pool = Pool(processes=min(len(scales_pxl), cpu_count()))
     for idx, scale_pxl in enumerate(scales_pxl):
         logger.info(
             f"Computing scale {scales[idx]} meters with smoothing factor"
             f" {smth_factors[idx]} ..."
         )
         names = _valley_ridge_names(scales[idx], mode, smth_factors[idx])
-        pool.apply_async(
-            _valley_ridge_wrap,
-            args=(
-                dem_ds,
-                scale_pxl,
-                mode,
-                flat_list,
-                sigmas[idx],
-                names,
-                ind_nans,
-                crop,
-                outdir,
-            ),
-        )
-
-    pool.close()
-    pool.join()
-
-
-def _valley_ridge_wrap(
-    dem_ds, size, mode, flat_list, sigma, names, ind_nans, crop, outdir
-):
-    """Wrapper to valley_ridge and hlp.to_netcdf functions to ease the parallelization
-    of the different scales"""
+        arrays = valley_ridge(dem_val, scale_pxl, mode, flat_list, sigmas[idx])
 
-    arrays = valley_ridge(hlp.get_da(dem_ds).values, size, mode, flat_list, sigma)
-    units = "1"
-    for array, name in zip(arrays, names):
-        array[ind_nans] = np.nan
-        hlp.to_netcdf(array, dem_ds, name, crop, outdir, units)
+        for array, name in zip(arrays, names):
+            array[ind_nans] = np.nan
+            hlp.to_netcdf(array, dem_ds, name, crop, outdir, units)
 
 
 @hlp.timer