Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add age plugin and fido2 hmac support #680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianmcgee
Copy link

No description provided.

@Mic92
Copy link
Owner

Mic92 commented Nov 23, 2024

Nice. Should we also point to your sops changes?

description = ''
List of plugins to use for sops decryption.
'';
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that also require age plugin support in sops?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow.

We should probably add the fido2-hmac plugin as a default in this option though.

Copy link
Owner

@Mic92 Mic92 Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need sops-nix to recognise these age plugin style age keys to not fail to run, even if they are not used?

@brianmcgee
Copy link
Author

Nice. Should we also point to your sops changes?

This points to my patched version of sops, which in turn relies on the patched versioned of age (purely as a lib).

@brianmcgee
Copy link
Author

To be quite honest I just looked at your PR and adapted it to use my sops. Maybe there's some extra steps missing here.

@Mic92
Copy link
Owner

Mic92 commented Nov 23, 2024

github.com/getsops/sops/v3 v3.8.1
this also needs to be replaced as far as I remember

@brianmcgee
Copy link
Author

I'll have a proper look rather than just copy pasta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants