Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Time to migrate from magrittr %>% to base pipe |>? #225

Closed
1 task done
JamesHWade opened this issue Aug 27, 2024 · 1 comment · Fixed by #226
Closed
1 task done

[FR]: Time to migrate from magrittr %>% to base pipe |>? #225

JamesHWade opened this issue Aug 27, 2024 · 1 comment · Fixed by #226
Labels
feature a feature request or enhancement

Comments

@JamesHWade
Copy link
Collaborator

What would you like to have?

R 4.1 was released over 3 years ago. Should we migrate to base pipe?

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JamesHWade JamesHWade added the feature a feature request or enhancement label Aug 27, 2024
@calderonsamuel
Copy link
Collaborator

I'm ok with this. We already have some calls of the base pipe in the source code.

https://github.com/search?q=repo%3AMichelNivard%2Fgptstudio+%7C%3E+path%3A%2F%5ER%5C%2F%2F&type=code

But let's first close the current open PR before start work on this

JamesHWade added a commit that referenced this issue Aug 31, 2024
@JamesHWade
update version, Closes #225
2c8907d
JamesHWade added a commit that referenced this issue Aug 31, 2024
@JamesHWade
update version, Closes #225
e5bc1e7
@JamesHWade JamesHWade mentioned this issue Aug 31, 2024
Merged
6 tasks
JamesHWade added a commit that referenced this issue Sep 3, 2024
@JamesHWade
%>% to |>, R >=4.1, update news, remove revdep, Fixes #225
9a57845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove magrittr MichelNivard/gptstudio
2 participants
@JamesHWade @calderonsamuel