Skip to content
This repository has been archived by the owner on Nov 11, 2021. It is now read-only.

Check video.error for null on MSE/EME demo #147

Open
hsivonen opened this issue Apr 15, 2016 · 4 comments
Open

Check video.error for null on MSE/EME demo #147

hsivonen opened this issue Apr 15, 2016 · 4 comments
Assignees

Comments

@hsivonen
Copy link

Steps to reproduce:

  1. Navigate to https://developer.microsoft.com/en-us/microsoft-edge/testdrive/demos/eme/ in Firefox.
  2. In the list of videos on the left, click any video that's not the currently-selected one.

Actual results:
A message "TypeError: video.error is null" is logged.

Expected results:
No error.

Additional info:
The error location is line 729 in demo.js, which reads:

if (video.error.msExtendedCode) {

That line should null-check video.error before trying to check the msExtendedCode property on it.

@hsivonen
Copy link
Author

CC @mohmoto

@dstorey
Copy link
Member

dstorey commented Apr 15, 2016

CC @molant

@molant
Copy link
Contributor

molant commented May 5, 2016

@mohmoto what do you want to do with this? As they say in webcompat/web-bugs#1855 Firefox doesn't support WebM content in EME yet.

@mohmoto
Copy link
Contributor

mohmoto commented May 6, 2016

I'll fix this. It's pretty low pri though as it's in an error path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants