Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger pausing on ignore listed files #243

Open
royalone opened this issue Apr 5, 2024 · 5 comments
Open

Debugger pausing on ignore listed files #243

royalone opened this issue Apr 5, 2024 · 5 comments
Labels
bug Something isn't working tracked This issue is now tracked on our internal backlog

Comments

@royalone
Copy link

royalone commented Apr 5, 2024

I have a bunch of files (mainly minified libraries) that I have added to the ignore list. When I open these files in the Sources tab, there is a banner at the bottom telling me that This script is on the debugger's ignore list

Adding breakpoints to these files will pause execution, and also checking the pause on caught/uncaught exceptions breakpoint options will pause in these ignore listed files.

This is mainly an issue to me when I want to pause on exceptions in my own code, but the pausing is polluted by all my libraries throwing and catching exceptions all the time.

Edge version:
Version 123.0.2420.81 (Official build) (64-bit)

Let me know if I can provide more info
Thanks

AB#50057122

@royalone royalone added the bug Something isn't working label Apr 5, 2024
@captainbrosset
Copy link
Contributor

captainbrosset commented Apr 8, 2024

Thank you for filing.

Adding breakpoints to these files will pause execution,

I'm not clear here on whether this should occur or not. I'll take a deeper look in a minute.

checking the pause on caught/uncaught exceptions breakpoint options

This should definitely not happen.

@captainbrosset
Copy link
Contributor

I can confirm the first one is intentional: even when you add a script to the ignore list, manually setting breakpoints within that script will still trigger those breakpoints. Manual breakpoints override the ignore script setting.

@captainbrosset
Copy link
Contributor

I just tested the second one: "checking the pause on caught/uncaught exceptions breakpoint options", and things seem to work fine for me. When I add the script to the ignore list, and then select the options, script execution does not pause within the ignored script.

@royalone could you please check again and make sure this is broken on your end? And, if so, please provide a test that we can use to reproduce the issue locally.

@royalone
Copy link
Author

royalone commented Apr 9, 2024

Digging a bit deeper, it's the ignore list general exclusion rules, specifically Content scripts injected by extensions that doesn't seem to be working for me.

  • Start with ignore listing enabled in settings, but no custom rules and no general rules
  • Open a file in Sources tab, right click and Add script to ignore list
  • Exceptions in this file will not pause execution as expected (this works fine)
  • Open an extension file in Sources tab, right click and select Add all extension scripts to ignore list
  • Banner pops up below for this and all extension files now stating that the script is on the debugger's ignore list
  • Exceptions in these files will pause execution

@captainbrosset
Copy link
Contributor

Thanks for the additional investigation details. I'll make sure this issue shows up on our team's radar for prioritization.

@captainbrosset captainbrosset added the tracked This issue is now tracked on our internal backlog label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked This issue is now tracked on our internal backlog
Projects
None yet
Development

No branches or pull requests

2 participants