Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow truncating path to variables #126

Open
cbiesinger opened this issue May 16, 2019 · 5 comments
Open

Allow truncating path to variables #126

cbiesinger opened this issue May 16, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@cbiesinger
Copy link
Collaborator

Today I wanted to show a member variable in the tree with a fairly long path:
Layer.scrollable_area_.raw_.scrollbar_manager_.v_bar_is_attached_:false

This takes up a lot of horizontal space... can we allow truncating them? Or always truncate in the middle when they get long enough, or something?

@cbiesinger cbiesinger added the enhancement New feature or request label May 16, 2019
@sanketj
Copy link
Member

sanketj commented May 16, 2019

Interesting idea!

For long paths, we could do something like: add a "..." in the middle and the show the full path when the user hits alt+click.

The question though is when do we decide to show the "...". After we expand through a certain number of fields? After we cross an arbitrary path size? Or would it have to vary based on window size? I'm not sure what the right answer is here.

@sanketj
Copy link
Member

sanketj commented May 16, 2019

@petersalas , have you ever thought about this?

@petersalas
Copy link
Contributor

Yeah, it can definitely be problem, especially when multiple fields are being showed and it's embarrassingly bad when it's a.really.long.sequence.of.objects.ending.in.fieldA and a.really.long.sequence.of.objects.ending.in.fieldB.

The ideas around trimming sound good to me...maybe elide fields between 2 and N-1?

cbiesinger added a commit to cbiesinger/JsDbg that referenced this issue Jun 21, 2019
When showing multiple variables in the tree display, this
makes it easier to scan the display for the value vs the
path.

Bug: MicrosoftEdge#126
cbiesinger added a commit that referenced this issue Jun 22, 2019
When showing multiple variables in the tree display, this
makes it easier to scan the display for the value vs the
path.

Bug: #126
@sanketj
Copy link
Member

sanketj commented Jun 24, 2019

@cbiesinger @petersalas , do we still want this now that we have #155 ?

@cbiesinger
Copy link
Collaborator Author

You could certainly make an argument either way but I'm leaning towards keeping this open because it would be helpful to conserve screen width when showing multiple variables with long paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants