-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web Install] Require manifest_id #746
Comments
The cross-origin explainer has been updated to require both a |
I'm still against the same-origin install not providing a manifest_id, and introduces potential flakiness of the API, as it's not uncommon for developers to add the manifest rel-link programatically, which can cause ordering issues. @marcoscaceres to prevent this API from being flaky would it be reasonable for WebKit to support parsing the manifest id for this API? |
I had a long chat with Reilly who helped me reason about this - I think this is ok for same-site installs assuming the API requires installability / it doesn't just use the default manifest. Optional works to help the developer confirm it's the right app, if they want. |
Given apple wants to have no restrictions on install (e.g. no manifest required), I'll re-open this. I created a doc: |
Writing down feedback here from our last chat:
Not requiring the manifest id introduces the edge case where the developer calls the API before they add the manifest link tag. In an effort to ensure a non-flaky platform, I'd rather have the manifest_id always included, and if there is a mismatch then the API can error appropriately.
The text was updated successfully, but these errors were encountered: