Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web Install] Require manifest_id #746

Open
dmurph opened this issue Jan 30, 2024 · 4 comments
Open

[Web Install] Require manifest_id #746

dmurph opened this issue Jan 30, 2024 · 4 comments
Assignees
Labels
Web Install API Declarative install for web apps from a web app.

Comments

@dmurph
Copy link

dmurph commented Jan 30, 2024

Writing down feedback here from our last chat:

Not requiring the manifest id introduces the edge case where the developer calls the API before they add the manifest link tag. In an effort to ensure a non-flaky platform, I'd rather have the manifest_id always included, and if there is a mismatch then the API can error appropriately.

@dmurph dmurph added the Web Install API Declarative install for web apps from a web app. label Jan 30, 2024
@amandabaker
Copy link
Member

The cross-origin explainer has been updated to require both a manifest_id and an install_url, but we still want to keep the option to install with no args for same-domain installs since, according to MDN docs, Safari doesn't support the manifest_id property in the manifest, and requiring this as a parameter would be counterproductive for gaining traction on another engine.

@dmurph
Copy link
Author

dmurph commented Apr 23, 2024

I'm still against the same-origin install not providing a manifest_id, and introduces potential flakiness of the API, as it's not uncommon for developers to add the manifest rel-link programatically, which can cause ordering issues.

@marcoscaceres to prevent this API from being flaky would it be reasonable for WebKit to support parsing the manifest id for this API?

@dmurph
Copy link
Author

dmurph commented Apr 24, 2024

I had a long chat with Reilly who helped me reason about this - I think this is ok for same-site installs assuming the API requires installability / it doesn't just use the default manifest. Optional works to help the developer confirm it's the right app, if they want.

@dmurph dmurph closed this as completed Apr 24, 2024
@dmurph
Copy link
Author

dmurph commented Jun 7, 2024

Given apple wants to have no restrictions on install (e.g. no manifest required), I'll re-open this. I created a doc:
https://bit.ly/navigator-install-and-manifest-identity

@dmurph dmurph reopened this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Install API Declarative install for web apps from a web app.
Projects
None yet
Development

No branches or pull requests

3 participants