Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web Install] Should install_sources be allowed_install_sources? #781

Closed
amandabaker opened this issue Apr 10, 2024 · 2 comments
Closed
Assignees
Labels
Web Install API Declarative install for web apps from a web app.

Comments

@amandabaker
Copy link
Member

This doesn't propose any functional changes to the API, but for the sake of clarity and future proofing the API, should install_sources be renamed to allowed_install_sources?

This improves clarity by showing that allowed_install_sources would behave the same way regardless of whether allow_all_install_sources is set to true, false, or is unset. Initially I thought that install_sources may function as a block list if allow_all_install_sources were set to true.

Additionally, it helps to future-proof the API if there is developer feedback that a list of blocked install sources is valuable (e.g. a developer wants to allow all origins to install their app except for a known malicious/questionable origin). Currently there is no signal that this is valuable, but switching to allowed_install_sources would help balance the potential blocked_install_sources if it were added in the future.

cc: @diekus @HowardWolosky @Kbhlee2121

@amandabaker amandabaker added the Web Install API Declarative install for web apps from a web app. label Apr 10, 2024
@diekus
Copy link
Member

diekus commented Apr 19, 2024

or should we just add a "action" field to the install_sources list? This would allow to specify to allow/deny installation from the origin that is in the entry.

Example:

"install_sources": [ 
        {"origin": "apps.microsoft.com", "action": "allow"},
        {"origin": "store.app", "action": "deny"}

    ]

@amandabaker
Copy link
Member Author

Related #785

@diekus diekus closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Install API Declarative install for web apps from a web app.
Projects
None yet
Development

No branches or pull requests

2 participants