Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow window-specific audio sharing in WebRTC streams #4327

Open
SpikeHD opened this issue Jan 27, 2024 · 3 comments
Open

[Feature]: Allow window-specific audio sharing in WebRTC streams #4327

SpikeHD opened this issue Jan 27, 2024 · 3 comments
Assignees
Labels
feature request feature request

Comments

@SpikeHD
Copy link

SpikeHD commented Jan 27, 2024

Describe the feature/enhancement you need

Window-specific audio sharing in WebRTC streams. Having the option to enable/disable audio in full-desktop streams is great, and I'd like to see that for specific windows as well!

The scenario/use case where you would use this feature

Using WebRTC to stream a window and it's specific audio to someone else. Especially important when talking to said person (eg. Discord), since the persons audio will mirror in the stream when doing full-desktop sharing.

How important is this request to you?

Impactful. My app's user experience would be significantly compromised without it.

Suggested implementation

An implementation identical to the current system audio one, where there is a checkbox in the screen sharing menu that toggles audio when window sharing. If enabled, the window's audio will be shared.

What does your app do? Is there a pending deadline for this request?

No response

@SpikeHD SpikeHD added the feature request feature request label Jan 27, 2024
@victorhuangwq
Copy link
Collaborator

Hi @dianaqu can you take a look at this feature request and see if this is something that can already be done?

@dianaqu
Copy link
Contributor

dianaqu commented Jan 30, 2024

@SpikeHD Hi! Could you provide some screenshot on the current behavior and desired behavior?

Just to clarify,
The user scenario is: When user is remote sharing screen that plays an audio (using your wv2 app), having the ability to enable/disable audio that System plays?

@SpikeHD
Copy link
Author

SpikeHD commented Jan 30, 2024

@dianaqu Hi! Thanks for getting back!

When sharing a specific window, a user is unable to share that window's audio:
image

However, when sharing their entire desktop, they are able to share system audio (but not window-specific audio):
image

What I am hoping for is the option to share window-specific (not system) audio when sharing that window. For example, if I were to share my FireFox window with a YouTube video playing, the audio would be audible to those I am streaming to, but something like my Spotify playback would not be. I imagine the implementation in WV2 would be similar to what is described in this WinAPI sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request
Projects
None yet
Development

No branches or pull requests

3 participants