Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify sample app in "New available version" dialog #185

Closed
mikehoffms opened this issue May 3, 2023 · 2 comments · Fixed by #186
Closed

Identify sample app in "New available version" dialog #185

mikehoffms opened this issue May 3, 2023 · 2 comments · Fixed by #186

Comments

@mikehoffms
Copy link
Contributor

mikehoffms commented May 3, 2023

I opened #186 to fix this issue.

  • Add a space after "We detected there is a new version for the browser." to separate the two sentences.
  • Change "Do you want to restart the app?" to "Do you want to restart the WebView2APISample app?"
    • I got this dialog out of the blue with no context. Add the name of the sample app in the dialog box to give context and indicate which app is referred to by the dialog.
  • Change "We detected there is a new version for the browser." to eg "A new version of Microsoft Edge is available on this machine."
    • A comment reads "This handler tells when there is a new Edge version available on the machine."
  • Maybe add hint words to clarify why would i want to re-create a webview.

MicrosoftTeams-image (4)

https://github.com/MicrosoftEdge/WebView2Samples/blob/main/SampleApps/WebView2APISample/AppWindow.cpp#L1806-L1814

                            L"We detected there is a new version for the browser.";
                        if (m_webView)
                        {
                            message += L"Do you want to restart the app? \n\n";
                            message +=
                                L"Click No if you only want to re-create the webviews. \n";
                            message += L"Click Cancel for no action. \n";
                        }
@mikehoffms mikehoffms changed the title Identify sample app in dialog "We detected there is a new version for the browser" Identify sample app in "New available version" dialog May 3, 2023
@mikehoffms
Copy link
Contributor Author

final version of sentence:
A new version of the Microsoft Edge WebView2 Runtime is available on this machine.

@mikehoffms
Copy link
Contributor Author

result encountered May 17, 2023:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant