Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support for new functionality after dockershim #185

Open
WMP opened this issue Apr 26, 2023 · 2 comments
Open

[Question] Support for new functionality after dockershim #185

WMP opened this issue Apr 26, 2023 · 2 comments

Comments

@WMP
Copy link

WMP commented Apr 26, 2023

In K8S 1.25 cgroupv2 ( kubernetes/enhancements#2254 ) is enabled, in containerD 1.7 ( https://github.com/containerd/containerd/blob/main/docs/NRI.md ) there is support for Node Resource Interface, and k8s 1.27 adds support for memory QoS ( kubernetes/enhancements#2570 ) . Using cri-dockerd will it be possible to use these functionalities?

@afbjorklund
Copy link
Contributor

afbjorklund commented Apr 26, 2023

Cgroups v2 is supported since Docker 20.10, and is default in eg Ubuntu 22.04

https://www.docker.com/blog/introducing-docker-engine-20-10/


But I believe that the new field (LinuxContainerResources) was not implemented for docker, only containerd and cri-o?

https://kubernetes.io/blog/2021/11/26/qos-memory-resources/

There is supposed to be a Config.Linux.Resources, now with a new key "Unified".

https://github.com/moby/moby/blob/master/api/types/container/hostconfig.go

@afbjorklund
Copy link
Contributor

I don't think there are any plans to implement the NRI adaptation for Docker, but I could be mistaken ?

The goal is to enable NRI support in the most commonly used OCI runtimes, containerd and CRI-O.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants