Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_tree_plot_for_tissue relies on ggraph version 2.1.0 #55

Open
christopherjin opened this issue May 7, 2024 · 4 comments
Open

get_tree_plot_for_tissue relies on ggraph version 2.1.0 #55

christopherjin opened this issue May 7, 2024 · 4 comments

Comments

@christopherjin
Copy link

Hi folks,

Went through a few testing iterations because I just couldn't get get_tree_plot_for_tissue to work at all. I was using ggraph v 2.2.1, which gives the following error. Re-installing to v 2.1.0 fixed the issue

Error message for 2.2.1

Error in `[<-`:
! Assigned data `d_g_our_layout[grepl("F0_M0", d_g_our_layout$name), "y"][1]` must be compatible with row subscript `d_g_our_layout$name ==
  "0w"`.
✖ 1 row must be assigned.
✖ Assigned data has 4 rows.
ℹ Row updates require a list value. Do you need `list()` or `as.list()`?
Caused by error in `vectbl_recycle_rhs_rows()`:
! Can't recycle input of size 4 to size 1.
Backtrace:
  1. MotrpacRatTraining6mo::get_tree_plot_for_tissue(...)
 14. tibble (local) `<fn>`(`<vctrs___>`)
 15. tibble:::vectbl_recycle_rhs_rows(value, length(i), i_arg, value_arg, call)
@nicolerg
Copy link
Collaborator

nicolerg commented May 7, 2024

Thanks, @christopherjin. I'll look into making it compatible with ggraph 2.2.1

@christopherjin
Copy link
Author

Thank you Nicole!

@simplefywoo
Copy link

Wow, it turns out that the version of this package conflicts, and it is really ok after replacing the version. I also thought that I did not use the get_tree_plot_for_tissue function correctly.

@nicolergay
Copy link

nicolergay commented Jun 14, 2024

Thanks for confirming. I will put out a fix soon.

nicolerg added a commit that referenced this issue Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants