Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can get an empty file if you're quick #52

Open
ryanseddon opened this issue Sep 27, 2015 · 5 comments
Open

You can get an empty file if you're quick #52

ryanseddon opened this issue Sep 27, 2015 · 5 comments

Comments

@ryanseddon
Copy link
Member

Modernizr/Modernizr#1681

If you have a fresh cache and you're reasonably fast you can beat the build tool and get just the default js without the test you selected.

modernizr

@joecritch any suggestions on ux around this? I was thinking of having the build button show a loading spinner in it?

@anacrolix
Copy link

I'm not sure you even need to be quick. If I follow @patrickkettner 's link https://modernizr.com/download?flexbox&q=flex, I get the expected code. However if I manually select flexbox, and hit build, I note the address bar is reading: https://modernizr.com/download?flexbox-setclasses&q=flex and I get

/*! modernizr 3.0.0-alpha.4 (Custom Build) | MIT *
 * http://modernizr.com/download/#- !*/
!function(n,o,c){}(window,document);

@patrickkettner
Copy link
Member

Quick is relative to the machine you are on, it appears

On Sep 28, 2015, at 8:59 PM, Matt Joiner notifications@github.com wrote:

I'm not sure you even need to be quick. If I follow @patrickkettner 's link https://modernizr.com/download?flexbox&q=flex, I get the expected code. However if I manually select flexbox, and hit build, I note the address bar is reading: https://modernizr.com/download?flexbox-setclasses&q=flex and I get

/*! modernizr 3.0.0-alpha.4 (Custom Build) | MIT *

@patrickkettner
Copy link
Member

@joecritch any opinion on what should be done in these situations?

@joecritch
Copy link
Contributor

@patrickkettner @ryanseddon An inline spinner on the (disabled) Build button sounds good to me. I think blocking the use of the lightbox at this point is a positive restriction. Do we have a stock spinner on this site yet?

@patrickkettner
Copy link
Member

No, we dont

On Oct 22, 2015, at 5:26 AM, Joe Critchley notifications@github.com wrote:

@patrickkettner @ryanseddon An inline spinner on the (disabled) Build button sounds good to me. I think blocking the use of the lightbox at this point is a positive restriction. Do we have a stock spinner on this site yet?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants