Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options for the HTTP client #9

Open
NickLarsenNZ opened this issue Feb 3, 2020 · 2 comments
Open

More options for the HTTP client #9

NickLarsenNZ opened this issue Feb 3, 2020 · 2 comments

Comments

@NickLarsenNZ
Copy link

While testing, I have an invalid certificate, and need to be able to skip TLS verification.
We also need to be able to provide basic auth, so I wonder if the provider can have additional options, such as:

provider "ksql" {
   url = "https://localhost:8083"

   skip_tls_verification = true

   auth {
      type     = "basic"
      username = "user"
      password = "password"
   }
}
@NickLarsenNZ
Copy link
Author

It looks like we'd need to adjust the ksql lib to be able to take in a custom HTTP client:

https://github.com/Mongey/ksql/blob/5c43a2bbee699b9d206d50451578bb61b75cd6bd/ksql/client.go#L33

@NickLarsenNZ
Copy link
Author

Should I create an issue over in mongey/ksql ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant