Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String representation of Fraction #1

Open
jbrucker opened this issue Aug 21, 2019 · 1 comment
Open

String representation of Fraction #1

jbrucker opened this issue Aug 21, 2019 · 1 comment

Comments

@jbrucker
Copy link
Collaborator

Your test cases look good.

About the string representation for n/0,
since we allow user to create fractions with denominator
zero, the str method should display it
(not an error message).

This allows arithmetic with "extended numbers", Infinity
and NaN (Not-a-Number). You don't need to worry about
operations with extended numbers, but please make
str return fractions with denominator=0
as ordinary fractions, e.g. "1/0", "-1/0", or "0/0",
not an error message.

@th-bunratta
Copy link
Collaborator

Those issues are resolved. I did know this issue, but I forgot to publish that. I'm still looking for more test cases to be discovered.

Anyway, thanks for pointing me out 🍡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants