Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event handlers to the form element instead of button clicks #123

Open
DennisRas opened this issue Apr 17, 2018 · 1 comment
Open

Move event handlers to the form element instead of button clicks #123

DennisRas opened this issue Apr 17, 2018 · 1 comment

Comments

@DennisRas
Copy link
Collaborator

This would allow the user to press enter when submitting a form.
I'm sure in some way, this would also add some additional points towards better accessibility.
And for mobile users they can use the "Move to the next form element" button with some keyboard apps which would submit the form at the last input.

Debug Information

In-Game Name: (if applicable)
Operating System: Win32
Browser/Version: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to Reproduce

  1. Go to the login page
  2. Select an input
  3. Press enter

Expected Behavior

  1. Form submission

Actual Behavior

  1. Nothing

Possible Solution

  • Move/add event handlers onto the form element.
  • Add type="submit" or remove type="button" from buttons that should submit the form.
@DennisRas
Copy link
Collaborator Author

DennisRas commented Apr 17, 2018

Other places with a similar issue:

@MrEliasen MrEliasen added this to the 0.2.0 milestone Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants