Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the version and/or latest commit hash in the game or lobby #81

Open
DennisRas opened this issue Feb 19, 2018 · 6 comments
Open

Show the version and/or latest commit hash in the game or lobby #81

DennisRas opened this issue Feb 19, 2018 · 6 comments

Comments

@DennisRas
Copy link
Collaborator

At the time and date of this issue I happened to run into the bug closed in #58 but I wasn't sure if it's because the game currently online was updated with the latest commits or not.

Would it be possible for the game to show/indicate which version and/or which commit it runs?
Either on the start page or header/footer.
Note: I mention commit hash since the game doesn't have versions atm.

@MrEliasen
Copy link
Owner

Version was only planned for 0.1+, but I can see how having the hash or something like that show up instead (maybe on login as part of the MOTD?) would be using during this phase as well.

Let me know what you think about having it in the MOTD or something

@DennisRas
Copy link
Collaborator Author

MOTD works as well, but I wonder if that would cover it if you were to report a bug or suggestion about the game itself (lobby, auth etc.)

@MrEliasen
Copy link
Owner

We could include the version/hash when reporting a bug, include it in the issue template. Just need to fetch it from either server or client somehow.

@DennisRas
Copy link
Collaborator Author

I guess #30 is related in some way.

@MrEliasen
Copy link
Owner

Temporary solutions will be added.
But before 0.1.0 is released a more stable solutions using husky package and auto bump will be implemented.

@MrEliasen MrEliasen added this to the 0.1.0 Release milestone Feb 22, 2018
@MrEliasen MrEliasen removed this from the 0.1.0 Release milestone Apr 9, 2018
@MrEliasen
Copy link
Owner

This is on-going until we decide exactly what we do with this. Currently it will show the hash of the commit the game is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants