Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting the formatter function? #14

Open
nolongerwait opened this issue Dec 23, 2021 · 4 comments
Open

Consider supporting the formatter function? #14

nolongerwait opened this issue Dec 23, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@nolongerwait
Copy link

In terms of current functional experience, this extension is the best among all the thrift extension in VS Code I have used.

But now almost all thrift plugins do not support native vscode format shortcuts(Shift + Option + F in macOS).

There is an extension(developed by our compatriots) that has a formatting function, but it is not very useful and has many problems when formatting.

@MrKou47
Copy link
Owner

MrKou47 commented Dec 31, 2021

Thank you for your suggestion! I will first see the official documentation to assess the complexity of implementation.

@MrKou47 MrKou47 self-assigned this Dec 31, 2021
@MrKou47 MrKou47 added the enhancement New feature or request label Dec 31, 2021
@nolongerwait
Copy link
Author

Thanks for the reply.
In fact, I am also thinking about learning how to add features to vscode extension by myself.
If you really don’t have time, I can follow up with a PR to enhance the extension.

However, as a C++ development, there may be a lot for me to learn. :-D

@MrKou47
Copy link
Owner

MrKou47 commented Jan 2, 2022

Sure! PR welcome!

@alingse
Copy link

alingse commented Dec 1, 2022

hi guys. i have write an another thrift formatter extension base on antlr4ts https://github.com/thrift-labs/thrift-fmt-vscode

欢迎体验 👀 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants