Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"window_control_placeholder_support.css" causes window controls to be in top middle #469

Open
aviadhaham opened this issue Nov 30, 2024 · 3 comments

Comments

@aviadhaham
Copy link

aviadhaham commented Nov 30, 2024

Issue

image

After updating to Firefox 1.33, the issue started, the window controls, instead of being top left as always, they started being at the top, but in middle ("floating" over the URL bar in my case).

After debugging using the devtools, I found the issue is here, in the marked element:
Issue Chronicle - How I Fixed the Firefox window controls out of order

Solution

I took the latest version of the CSS file (github), added the below CSS, and it solved it:

/* To fix the weird position of the window controls from the middle to the left */
#TabsToolbar {
  justify-content: normal !important;
}

@MrOtherGuy If that's good for you, I can create a PR. I wanted to share first about the issue.

@MrOtherGuy
Copy link
Owner

I'd rather not touch window_control_placeholder_support.css at all anymore. It should not be used in Firefox 133 anymore. For styles that did depend on it there are now better ways to do things.

@matru
Copy link

matru commented Nov 30, 2024

I'd rather not touch window_control_placeholder_support.css at all anymore. It should not be used in Firefox 133 anymore. For styles that did depend on it there are now better ways to do things.

What's the alternative way to handle this then? Simply commenting out window_control_placeholder_support.css will not work.

@MrOtherGuy
Copy link
Owner

Look up a "_v2" variant of whatever style you were using that required window_control_placeholder_support and simply use that.

If there isn't one then let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants