Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests temporarily disabled in #1138 #1140

Open
JakeQZ opened this issue Dec 17, 2021 · 0 comments
Open

Re-enable tests temporarily disabled in #1138 #1140

JakeQZ opened this issue Dec 17, 2021 · 0 comments
Labels
cleanup

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 17, 2021 •
edited
Loading

See #1138. As and when they can be so can't set milestone.
@JakeQZ JakeQZ added the cleanup label Dec 17, 2021
@oliverklee oliverklee modified the milestone: 7.0.0 Dec 17, 2021
JakeQZ added a commit that referenced this issue Dec 21, 2021
@JakeQZ
[TASK] Pass debug setting on to CSS parser
73aaab4 
This partially addresses both #1139 and #1140.

However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.

Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
@JakeQZ JakeQZ mentioned this issue Dec 21, 2021
Merged
JakeQZ added a commit that referenced this issue Jan 12, 2022
@JakeQZ
[TASK] Pass debug setting on to CSS parser
73a5987 
This partially addresses both #1139 and #1140.

However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.

Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
oliverklee pushed a commit that referenced this issue Jan 12, 2022
@JakeQZ
[TASK] Pass debug setting on to CSS parser (#1142)
1290db3 
This partially addresses both #1139 and #1140.

However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.

Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverklee @JakeQZ