Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a branch without an upper PHP version limit #1210

Open
oliverklee opened this issue Jan 16, 2023 · 4 comments
Open

Add a branch without an upper PHP version limit #1210

oliverklee opened this issue Jan 16, 2023 · 4 comments
Assignees
Milestone

Comments

@oliverklee
Copy link
Contributor

Also automatically rebase it from main.

@oliverklee oliverklee added this to the 8.0.0 milestone Jan 16, 2023
@oliverklee oliverklee self-assigned this Jan 16, 2023
@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 7, 2023

As I understand, this would be a branch available via Composer like the -dev branch, but would not have any 'releases'. Or could it have automatic mirrored releases, with some kind of suffix (like there is -alpha and -beta - though I'm not sure what suffix we should choose for these, or if there is a precedent set by other projects)? People would then be able to use it via Composer in situations where the upper PHP version limit is restrictive in ways we haven't foreseen.

@oliverklee
Copy link
Contributor Author

As I understand, this would be a branch available via Composer like the -dev branch, but would not have any 'releases'.

Exactly. And we can regularly rebase it on the main branch (or automate that via a GitHub action).

@oliverklee
Copy link
Contributor Author

AFAIK, there is no naming convention for this.

@mvorisek
Copy link

mvorisek commented Sep 7, 2023

@mvorisek, thanks for sharing your experience; useful feedback and good to know. Feel free to further comment on #1210 there.

I maintain several large php projects and the simplest and most powefull solution is to not drop older PHP versions support too early. The PHP changes needed between PHP 7.4 and PHP 8.0 are minimal. The only limitation is how early a new PHP features can be uses, but they are mostly syntactical sugars...

The most important thing is to test everyting using CI - here is an example https://github.com/atk4/core/blob/9a3ff6928/.github/workflows/test-unit.yml#L80 which tests also if the lowest deps pass all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants