-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause processing others' tx and votes after own epoch change #17
Comments
I think it is safe to stop processing fast path votes at any time, as long
as we process certificates in commits
…On Fri, Aug 4, 2023 at 6:05 PM Kushal Babel ***@***.***> wrote:
When epoch changes, we stop casting our own votes and proposing
transactions.
But currently, we still process others' votes (these votes will appear in
our blocks' causal history) -- namely, aggregating them and checking for
certificate formation.
Is it safe to stop processing others' votes? This would translate to
essentially not calling the BlockHandler::handle_block method when we are
changing the epoch.
Relevant original discussion : #11 (review)
<#11 (review)>
and #11 (comment)
<#11 (comment)>
—
Reply to this email directly, view it on GitHub
<#17>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWVVQIUCMXLKCYTSAFUHNLXTUMU7ANCNFSM6AAAAAA3EM5FKA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When epoch changes, we stop casting our own votes and proposing transactions.
But currently, we still process others' votes (these votes will appear in our blocks' causal history) -- namely, aggregating them and checking for certificate formation.
Is it safe to stop processing others' votes? This would translate to essentially not calling the
BlockHandler::handle_block
method when we are changing the epoch.Relevant original discussion : #11 (review) and #11 (comment) and #11 (review)
The text was updated successfully, but these errors were encountered: