Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause processing others' tx and votes after own epoch change #17

Open
kushal-babel opened this issue Aug 4, 2023 · 1 comment
Open

Comments

@kushal-babel
Copy link
Contributor

kushal-babel commented Aug 4, 2023

When epoch changes, we stop casting our own votes and proposing transactions.
But currently, we still process others' votes (these votes will appear in our blocks' causal history) -- namely, aggregating them and checking for certificate formation.
Is it safe to stop processing others' votes? This would translate to essentially not calling the BlockHandler::handle_block method when we are changing the epoch.
Relevant original discussion : #11 (review) and #11 (comment) and #11 (review)

@andll
Copy link
Collaborator

andll commented Aug 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants