Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic types for daemon communication #15

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: add basic types for daemon communication #15

merged 1 commit into from
Sep 27, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Sep 26, 2023 •
edited
Loading

@mlegner mlegner added enhancement New feature or request rust labels Sep 26, 2023
@mlegner mlegner requested a review from jpcsmith as a code owner September 26, 2023 13:24
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion/src 100% ✔
crates/scion/src/address 100% ✔
crates/scion/src/daemon 0% ❌
Summary 100% (103 / 103) ✔

@mlegner mlegner enabled auto-merge (rebase) September 27, 2023 08:55
jpcsmith
jpcsmith approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, looks good, but I added a few suggestions to simplify it.

crates/scion/src/daemon/types.rs Outdated Show resolved Hide resolved
crates/scion/src/address/ia.rs Outdated Show resolved Hide resolved
crates/scion/src/daemon/types.rs Outdated Show resolved Hide resolved
@mlegner mlegner requested a review from jpcsmith September 27, 2023 11:11
@mlegner mlegner merged commit b66eb56 into main Sep 27, 2023
11 checks passed
@mlegner mlegner deleted the feat/daemon-types branch September 27, 2023 11:21
@mlegner mlegner mentioned this pull request Nov 20, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith